[Ad-hoc] Account for LazyUuidFromString on Uuid generation #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generation of Uuid objects received a substantial improvement in this PR ramsey/uuid#324 which introduced the new object being returned from the default UuidFactory.
|
This PR also supersedes the changes in #34 |
|
@lcobucci is this something we could release in |
|
Upgrading dependencies isn't really part of a patch IMHO. But I disagree here... I mean, the library has done things that improve performance quite a lot but nothing changed in terms of interface, so what's the point of changing the test expectations? Why not simply updating the dependency? Nevermind... now I see that this fixes the test 🤦 |
lcobucci
approved these changes
Jul 30, 2020
agustingomes
deleted the
ad-hoc/adopt-lazy-uuid-from-string-for-failing-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generation of Uuid objects received a substantial improvement
in this PR ramsey/uuid#324 which introduced
the new object being returned from the default UuidFactory.