Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(handlers.js): server crash when target ws server closes. #47

Merged
merged 1 commit into from Jan 18, 2016
Merged

fix(handlers.js): server crash when target ws server closes. #47

merged 1 commit into from Jan 18, 2016

Conversation

chimurai
Copy link
Owner

fixes #44

@mjrussell
Copy link

@chimurai this works great! Definitely resolves #44. The one (minor) issue I see is in the logging. I don't think it would prevent merging this though.

[HPM] Upgrading to WebSocket
[HPM] Client disconnected
[HPM] Proxy error: ECONNREFUSED. 127.0.0.1 -> "127.0.0.1:9020/api/users/me"
[HPM] Upgrading to WebSocket
[HPM] Proxy error: ECONNREFUSED. undefined -> "127.0.0.1:9020/api/event/eventFeed"

The undefined is my socket proxy, seems like that should be the host if we have that information

@chimurai chimurai force-pushed the Fix-Server-Crash-on-WS-Proxy-Server-Connection-Close branch from df729db to 30c0c68 Compare January 18, 2016 21:24
chimurai added a commit that referenced this pull request Jan 18, 2016
@chimurai
Merge pull request #47 from chimurai/Fix-Server-Crash-on-WS-Proxy-Ser…
9d083fb 
…ver-Connection-Close

fix(handlers.js): server crash when target ws server closes.
@chimurai chimurai merged commit 9d083fb into master Jan 18, 2016
@chimurai
Copy link
Owner Author

Thanks for reporting and testing.
Logging issue has been fixed as well. :-)

@chimurai chimurai deleted the Fix-Server-Crash-on-WS-Proxy-Server-Connection-Close branch January 18, 2016 21:33
@mjrussell
Copy link

👏 Thank you! I'll PR this into webpack-dev-server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy Failure on WS Proxy Server Connection Close
2 participants
@chimurai @mjrussell