Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): fix type regression #700

Merged
merged 1 commit into from
Jan 23, 2022
Merged

fix(types): fix type regression #700

merged 1 commit into from
Jan 23, 2022

Conversation

chimurai
Copy link
Owner

Description

Fix regression in types introduced in #603

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.86% when pulling 42cbc87 on type-regression into aaa15a9 on master.

@chimurai chimurai merged commit 6b5d7a8 into master Jan 23, 2022
@chimurai chimurai deleted the type-regression branch January 23, 2022 15:24
@AviVahl AviVahl mentioned this pull request Jan 24, 2022
Closed
2 tasks
@chimurai chimurai mentioned this pull request Feb 26, 2022
Closed
@chimurai chimurai mentioned this pull request Feb 22, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type regression (express.Request -> http.IncomingMessage) Breaking change in 2.0.1
2 participants
@chimurai @coveralls