Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proxyReqWs): catch socket errors #763

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Conversation

chimurai
Copy link
Owner

Description

Add socket error handler for proxyReqWs

Motivation and Context

hopefully fixes: webpack/webpack-dev-server#1642
related: #759

How has this been tested?

Relying on feedback from: webpack/webpack-dev-server#1642 (comment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.315% when pulling 9bd9c7e on proxyReqWs-socket-error-handler into f64c994 on 2.x.

@chimurai chimurai merged commit 3f48d50 into 2.x Apr 20, 2022
@chimurai chimurai deleted the proxyReqWs-socket-error-handler branch April 20, 2022 19:49
@chimurai chimurai linked an issue Apr 23, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hpm 1.0.6 Erroring for sockets when target server is restarted
2 participants