Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(responseInterceptor): fix header manipulation example #967

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

mcgwiz
Copy link
Contributor

@mcgwiz mcgwiz commented Feb 8, 2024

Description

responseInterceptor expects its function argument to return a value that can be passed to Buffer.from.

Motivation and Context

The documentation is misleading.

How has this been tested?

Confirmed locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@coveralls
Copy link

Coverage Status

coverage: 97.619%. remained the same
when pulling e9ab06f on mcgwiz:patch-1
into 84bfa46 on chimurai:master.

@chimurai chimurai changed the title Fix bug in header manipulation example docs(responseInterceptor): fix header manipulation example Apr 5, 2024
@chimurai chimurai merged commit f01dea1 into chimurai:master Apr 5, 2024
8 checks passed
@chimurai
Copy link
Owner

chimurai commented Apr 5, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants