Merge pull request #699 from chinapandaman/PPF-698

PPF-698: fix remaining fixable pyright issues

PyPDFForm/middleware/dropdown.py

@@ -16,7 +16,7 @@ def __init__(
 
         super().__init__(name, value)
 
-        self.choices = None
+        self.choices = []
 
     @property
     def schema_definition(self) -> dict:

PyPDFForm/middleware/text.py

@@ -22,7 +22,7 @@ def __init__(
         self.text_wrap_length = None
         self.max_length = None
         self.comb = None
-        self.character_paddings = None
+        self.character_paddings = []
         self.text_lines = None
         self.text_line_x_coordinates = None
         self.preview = False

pyrightconfig.json

@@ -2,17 +2,17 @@
     "typeCheckingMode": "basic",
     "reportArgumentType": "none",
     "reportAttributeAccessIssue": "none",
-    "reportOptionalSubscript": "none",
     "reportIndexIssue": "none",
     "reportOperatorIssue": "none",
     "reportGeneralTypeIssues": "none",
-    "reportOptionalMemberAccess": "none",
+    "reportOptionalMemberAccess": "error",
     "reportPossiblyUnboundVariable": "error",
     "reportUnusedImport": "error",
     "reportIncompatibleMethodOverride": "error",
     "reportMissingSuperCall": "error",
     "reportPrivateUsage": "error",
     "reportSelfClsParameterName": "error",
     "reportReturnType": "error",
-    "reportAssignmentType": "error"
+    "reportAssignmentType": "error",
+    "reportOptionalSubscript": "error"
 }

scripts/bump_version.py

@@ -11,11 +11,14 @@
         print("Bump version cannot be done on a non-issue branch.")
         sys.exit(1)
 
+    v = ""
     with open("PyPDFForm/__init__.py", encoding="utf8") as f:
-        version = re.search(r'__version__ = "(.*?)"', f.read()).group(1)
+        version = re.search(r'__version__ = "(.*?)"', f.read())
+        if version:
+            v = v.group(1)
 
     new_version = ".".join(
-        version.split(".")[:-1] + [str(int(version.split(".")[-1]) + 1)]
+        v.split(".")[:-1] + [str(int(v.split(".")[-1]) + 1)]
     )
 
     with open("PyPDFForm/__init__.py", encoding="utf8") as f:

scripts/create_release.py

@@ -10,7 +10,9 @@
 
 if __name__ == "__main__":
     with open("PyPDFForm/__init__.py", encoding="utf8") as f:
-        version = re.search(r'__version__ = "(.*?)"', f.read()).group(1)
+        version = re.search(r'__version__ = "(.*?)"', f.read())
+        if version:
+            version = version.group(1)
 
     latest_version = sys.argv[1].replace("(", "").replace(")", "")
     print(f"Latest deployed version: v{latest_version}.")

setup.py

@@ -6,7 +6,9 @@
 import setuptools
 
 with open("PyPDFForm/__init__.py", encoding="utf8") as f:
-    version = re.search(r'__version__ = "(.*?)"', f.read()).group(1)
+    version = re.search(r'__version__ = "(.*?)"', f.read())
+    if version:
+        version = version.group(1)
 
 with open("README.md", mode="r", encoding="utf-8") as fh:
     long_description = fh.read()