Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hujun 20181027 #128

Closed
wants to merge 9 commits into from
Closed

Hujun 20181027 #128

wants to merge 9 commits into from

Conversation

mindjun
Copy link
Contributor

@mindjun mindjun commented Nov 24, 2018

add function in issue #98, #100, #116

@coveralls
Copy link

Pull Request Test Coverage Report for Build 263

  • 41 of 43 (95.35%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 83.656%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fishbase/fish_common.py 26 28 92.86%
Totals Coverage Status
Change from base Build 256: 0.9%
Covered Lines: 389
Relevant Lines: 465

💛 - Coveralls

4 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 263

  • 41 of 43 (95.35%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 83.656%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fishbase/fish_common.py 26 28 92.86%
Totals Coverage Status
Change from base Build 256: 0.9%
Covered Lines: 389
Relevant Lines: 465

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 263

  • 41 of 43 (95.35%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 83.656%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fishbase/fish_common.py 26 28 92.86%
Totals Coverage Status
Change from base Build 256: 0.9%
Covered Lines: 389
Relevant Lines: 465

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 263

  • 41 of 43 (95.35%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 83.656%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fishbase/fish_common.py 26 28 92.86%
Totals Coverage Status
Change from base Build 256: 0.9%
Covered Lines: 389
Relevant Lines: 465

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 263

  • 41 of 43 (95.35%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 83.656%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fishbase/fish_common.py 26 28 92.86%
Totals Coverage Status
Change from base Build 256: 0.9%
Covered Lines: 389
Relevant Lines: 465

💛 - Coveralls

@@ -54,14 +54,14 @@ A Simple Example

from fishbase.fish_common import GetMD5

# 获取字符换的MD5值
# 获取字符换的 MD5 值
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该是获取字符 ”串“ 的 MD5 ,不是字符 ”换“

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,我修改下

2018.10.27 v1.1.2
---------------------------
* `#80 <https://github.com/chinapnr/fishbase/issues/80>`_, common, add function :meth:`fish_common.find_common_between_dicts`, doc and unittest;
* `#80 <https://github.com/chinapnr/fishbase/issues/80>`_, common, add function :meth:`fish_common.find_same_between_dicts`, doc and unittest;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样的改变应当放到本期的办理修改里,而不是直接修改上个版本的 change_log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是上期修改,然后没有提交的


:param:
* source: (list, set, dict) 需要检查的对象

:return:
* result: (bool) 存在None或空字符串或空格字符串返回True, 否则返回False
* result: (bool) 存在None或空字符串或空格字符串返回 True, 否则返回 False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None 两边缺少空格

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯,我都检查下

@itaa itaa closed this Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants