New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hujun 20181027 #128
Hujun 20181027 #128
Conversation
…ame from find_same_between_dicts to find_same_between_dicts
Pull Request Test Coverage Report for Build 263
💛 - Coveralls |
4 similar comments
Pull Request Test Coverage Report for Build 263
💛 - Coveralls |
Pull Request Test Coverage Report for Build 263
💛 - Coveralls |
Pull Request Test Coverage Report for Build 263
💛 - Coveralls |
Pull Request Test Coverage Report for Build 263
💛 - Coveralls |
@@ -54,14 +54,14 @@ A Simple Example | |||
|
|||
from fishbase.fish_common import GetMD5 | |||
|
|||
# 获取字符换的MD5值 | |||
# 获取字符换的 MD5 值 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里应该是获取字符 ”串“ 的 MD5 ,不是字符 ”换“
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,我修改下
2018.10.27 v1.1.2 | ||
--------------------------- | ||
* `#80 <https://github.com/chinapnr/fishbase/issues/80>`_, common, add function :meth:`fish_common.find_common_between_dicts`, doc and unittest; | ||
* `#80 <https://github.com/chinapnr/fishbase/issues/80>`_, common, add function :meth:`fish_common.find_same_between_dicts`, doc and unittest; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样的改变应当放到本期的办理修改里,而不是直接修改上个版本的 change_log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是上期修改,然后没有提交的
|
||
:param: | ||
* source: (list, set, dict) 需要检查的对象 | ||
|
||
:return: | ||
* result: (bool) 存在None或空字符串或空格字符串返回True, 否则返回False | ||
* result: (bool) 存在None或空字符串或空格字符串返回 True, 否则返回 False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None 两边缺少空格
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯,我都检查下
add function in issue #98, #100, #116