Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hujun 20190328 #219

Merged
merged 4 commits into from Apr 3, 2019
Merged

Hujun 20190328 #219

merged 4 commits into from Apr 3, 2019

Conversation

mindjun
Copy link
Contributor

@mindjun mindjun commented Apr 2, 2019

optimize from issue #215 and #218

@coveralls
Copy link

Pull Request Test Coverage Report for Build 487

  • 17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 89.728%
Totals Coverage Status
Change from base Build 484: 0.09%
Covered Lines: 725
Relevant Lines: 808
💛 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 487

  • 17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 89.728%
Totals Coverage Status
Change from base Build 484: 0.09%
Covered Lines: 725
Relevant Lines: 808
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 487

  • 17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 89.728%
Totals Coverage Status
Change from base Build 484: 0.09%
Covered Lines: 725
Relevant Lines: 808
💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 2, 2019 •
edited

Pull Request Test Coverage Report for Build 487

  • 17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 89.728%
Totals Coverage Status
Change from base Build 484: 0.09%
Covered Lines: 725
Relevant Lines: 808
💛 - Coveralls

@itaa itaa merged commit 2523898 into v1.1.8_develop Apr 3, 2019
@mindjun mindjun deleted the hujun_20190328 branch April 12, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mindjun @coveralls @itaa