Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code-blast.js #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update code-blast.js #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code-blast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ https://twitter.com/JoelBesada/status/670343885655293952
cmNode = cm.getWrapperElement();
init();
} else {
destroy();
if(cm) destroy();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can such a case arise? Also destroy shouldn't have a check on cm. Instead the cm.off statement should be checked for cm inside the destroy function so that rest of the destroy proceeds as usual.

}

});
Expand Down