Add commented out failing test

chinedufn · Mar 15, 2019 · 404dd70 · 404dd70
1 parent 77cb5fc
commit 404dd70
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 9 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -24,8 +24,8 @@ jobs:
           keys:
             # Checksum ensures that when we update versions for our `html-macro` dependencies we clear our cache, otherwise
             # compiletest-rs can error when the target directory has multiple versions of a crate.
-            - v5-cargo-cache-test-{{ arch }}-{{ .Branch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
-            - v5-cargo-cache-test-{{ arch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
+            - v6-cargo-cache-test-{{ arch }}-{{ .Branch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
+            - v6-cargo-cache-test-{{ arch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
 
       # Install nightly & wasm
       - run:
@@ -65,12 +65,12 @@ jobs:
 
       # Save cache
       - save_cache:
-          key: v5-cargo-cache-test-{{ arch }}-{{ .Branch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
+          key: v6-cargo-cache-test-{{ arch }}-{{ .Branch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
           paths:
             - target
             - /usr/local/cargo
       - save_cache:
-          key: v5-cargo-cache-test-{{ arch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
+          key: v6-cargo-cache-test-{{ arch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
           paths:
             - target
             - /usr/local/cargo
@@ -84,8 +84,8 @@ jobs:
       # Multiple caches are used to increase the chance of a cache hit.
       - restore_cache:
           keys:
-            - v5-cargo-cache-docs-{{ arch }}-{{ .Branch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
-            - v5-cargo-cache-docs-{{ arch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
+            - v6-cargo-cache-docs-{{ arch }}-{{ .Branch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
+            - v6-cargo-cache-docs-{{ arch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
 
       # Install nightly
       - run:
@@ -120,12 +120,12 @@ jobs:
 
       # Save cache
       - save_cache:
-          key: v5-cargo-cache-docs-{{ arch }}-{{ .Branch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
+          key: v6-cargo-cache-docs-{{ arch }}-{{ .Branch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
           paths:
             - target
             - /usr/local/cargo
       - save_cache:
-          key: v5-cargo-cache-docs-{{ arch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
+          key: v6-cargo-cache-docs-{{ arch }}-{{ checksum "./crates/html-macro/Cargo.toml" }}-{{ checksum "./crates/virtual-dom-rs/Cargo.toml" }}
           paths:
             - target
             - /usr/local/cargo

diff --git a/crates/html-macro-test/Cargo.toml b/crates/html-macro-test/Cargo.toml
@@ -7,4 +7,4 @@ edition = "2018"
 [dependencies]
 html-macro = {path = "../html-macro"}
 virtual-node = {path = "../virtual-node"}
-compiletest_rs = "0.3"
+compiletest_rs = "0.3.19"
diff --git a/crates/html-macro-test/src/lib.rs b/crates/html-macro-test/src/lib.rs
@@ -1,3 +1,9 @@
+//! Tests for our html! procedural macro
+//!
+//! To run all tests in this library:
+//!
+//! cargo test --color=always --package html-macro-test --lib "" -- --nocapture
+
 #![feature(proc_macro_hygiene)]
 
 use html_macro::html;

diff --git a/crates/virtual-dom-rs/tests/closures.rs b/crates/virtual-dom-rs/tests/closures.rs
@@ -1,5 +1,9 @@
 //! Ensure that our DomUpdater maintains Rc's to closures so that they work even
 //! after dropping virtual dom nodes.
+//!
+//! To run all tests in this file:
+//!
+//! wasm-pack test crates/virtual-dom-rs --chrome --headless -- --test closures
 
 #![feature(proc_macro_hygiene)]
 
@@ -85,6 +89,18 @@ fn closure_not_dropped() {
     );
 }
 
+// We're just making sure that things compile - other tests give us confidence that the closure
+// will work just fine.
+//
+// https://github.com/chinedufn/percy/issues/81
+//
+//#[wasm_bindgen_test]
+//fn closure_with_no_params_compiles() {
+//    let _making_sure_this_works = html! {
+//        <div onclick=|| {}></div>
+//    };
+//}
+
 fn make_input_component(text_clone: Rc<RefCell<String>>) -> VirtualNode {
     html! {
         <input