Fix parsing slices #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinedufn
commented
Apr 21, 2020
| // Would be great to find a better solution for this | ||
| // | ||
| // @see tests/slices_resource.rs | ||
| if number_of_slices == 65536 { |
There was a problem hiding this comment.
I just have no idea .. But once I add this both the test file as well as the file in my real project work.
My only guess is that [0, 1, 0, 0] for the number of slices means something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where my files that weren't even using
psdslices started panicking as of0.1.16.I'm not too familiar with slices - so it's possible that they can be automatically created in some cases. I don't know.
This PR adds a test case where I create a 1x1 white pixel PSD file and it panics when parsing the name of a group of slices. I did not add any slices to this file.
The crash appears to only happen when the name of the PSD (without them stem) is a certain length. So a fifteen character name such as
fiteen-letters.psdcrashes, a 23 character name crashes, but other lengths don't.This PR also removes the individual descriptor file tests in favor of testing against real PSD files. I was finding that while trying to debug those files weren't helping me because there was no way to know whether or not they were correct and how to reason about the data within them.