[feature] Rewrite renderer to iterative algorithm #35
Conversation
|
The exact issue is that browser goes OOM and kills the process - on my rig it takes a little over 3Gb - which happens even on small (< 100Mb) designs. |
|
Identified another 20% performance improvement - hash map usage :) |
|
Heads up -> I'm a bit swamped at the moment. I will review this and the other PR either today or this weekend. |
|
Sure, sorry for notification spam, found one 20% speedup; now: https://share.firefox.dev/3amCL1n :) |
scoiatael
force-pushed
the
lczaplinski/iterative-renderer
branch
from
6a1eb35
to
5cb52fd
Compare
src/psd_channel.rs
Outdated
| @@ -159,7 +159,10 @@ pub trait IntoRgba { | |||
| let bytes_to_read = 1 + header; | |||
| for byte in cursor.read(bytes_to_read as u32) { | |||
| let rgba_idx = self.rgba_idx(idx); | |||
| rgba[rgba_idx * 4 + offset] = *byte; | |||
| let target = rgba_idx * 4 + offset; | |||
| if target < rgba.len() { | |||
There was a problem hiding this comment.
What's the idea behind adding this if statement?
When do you expect this case to be hit and why shouldn't we panic?
src/psd_channel.rs
Outdated
| @@ -168,7 +171,10 @@ pub trait IntoRgba { | |||
| let byte = cursor.read_1()[0]; | |||
| for _ in 0..repeat as usize { | |||
| let rgba_idx = self.rgba_idx(idx); | |||
| rgba[rgba_idx * 4 + offset] = byte; | |||
| let target = rgba_idx * 4 + offset; | |||
| if target < rgba.len() { | |||
There was a problem hiding this comment.
What's the idea behind adding this if statement?
When do you expect this case to be hit and why shouldn't we panic?
There was a problem hiding this comment.
I hit this particular problem in a couple of my test files, so this fix was part of the branch I was cherry-picking from - must've made a mistake to pull them in this PR. Will open a new one with some tests for this edge-case :) Same for the one above.
There was a problem hiding this comment.
Woooo excited for those tests. Ok great thanks for explaining.
it was part of my testing branch and looks like I made a mistake whilst cherry-picking. will come back with some tests for this case :)
|
@CodeWitchBella wanna take a look? |
|
Thanks so much for this performance improvement! Released as 0.3.2 |
Yo,
during some testing discovered that recursive algorithm sometimes breaks in the demo - this should fix it :)
I should have one more PR soon which adds support for newer PS slice format (version 7 and 8).