Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error message in SharedStructDeclarationParser when an un… #244

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

bes
Copy link
Contributor

@bes bes commented Sep 10, 2023

…supported attribute is found

The panic message now contains the name of the unsupported attribute as well as the name of the struct that the attribute was found on.

This commit also updates the documentation to fix faulty struct attributes.

…supported attribute is found

The panic message now contains the name of the unsupported attribute as well
as the name of the struct that the attribute was found on.

This commit also updates the documentation to fix faulty struct attributes.
@bes
Copy link
Contributor Author

bes commented Sep 10, 2023

I just got bit by this yesterday, when upgrading swift-bridge from 0.1.49 to latest.

I had used #[swift_bridge::bridge(swift_repr = "struct")] on a struct, but that syntax is unsupported.

The correct syntax is #[swift_bridge(swift_repr = "struct")].

@chinedufn chinedufn merged commit d527f32 into chinedufn:master Sep 10, 2023
5 checks passed
@chinedufn
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants