Fix whitespace parsing #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Gelio ! Sorry that you ran into those whitespace issues. Thanks so much for not only fixing it but also tossing in some tests. This is 🔥 ! LGTM! |
|
Just published |
|
Wow, thank you for such a quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, great library. It saved me some time!
I have had some problems when parsing an *.obj file I downloaded from the Internet.
It had two spaces after the initial token and another space at the end of the line, like so:
It produced
nullvalues quite often.I added a test for that case and fixed the parsing process by trimming each line and then splitting by multiple whitespace characters with a regex, instead of just a space as the delimiter.