make sure createElement is not changed

chinesedfan · Jul 7, 2018 · 43be935 · 43be935
1 parent 56b2b54
commit 43be935
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/wrapper/jsonp.js b/src/wrapper/jsonp.js
@@ -18,6 +18,8 @@ function init(wrapUrl, jsonpKey) {
                     setAttribute.call(node, label, value);
                 };
 
+                // don't afraid that `node.prototype` is changed
+                // because `desc` is just a copy
                 var desc = Object.getOwnPropertyDescriptor(Object.getPrototypeOf(node), 'src');
                 var setter = desc.set;
                 desc.set = function(value) {

diff --git a/test/wrapper/jsonp.test.js b/test/wrapper/jsonp.test.js
@@ -46,7 +46,7 @@ describe('jsonp', function() {
                 runScripts: 'outside-only'
             });
             const win = dom.window;
-            const createElement = win.document.createElement;
+            win.oldCreateElement = win.document.createElement;
             // prepare in sub-jsdom
             if (window[coverageVar]) {
                 // hack
@@ -58,15 +58,21 @@ describe('jsonp', function() {
             win.eval(`
                 (${jsonp.init.toString()})(wrapUrl);
                 window.script = document.createElement('script');
-                script.src = 'path';
+                script.src = 'path'; // do nothing
+
+                window.script2 = oldCreateElement.call(document, 'script');
+                script2.src = 'path2?callback=1'; // also do nothing
             `);
 
-            expect(win.document.createElement).not.toBe(createElement);
+            expect(win.document.createElement).not.toBe(win.oldCreateElement);
             expect(wrapUrl).toHaveBeenCalledTimes(0);
 
             const script = win.script;
             expect(script.src).toEqual('https://xx.com/path');
             expect(script.getAttribute('src')).toEqual('path');
+            const script2 = win.script2;
+            expect(script2.src).toEqual('https://xx.com/path2?callback=1');
+            expect(script2.getAttribute('src')).toEqual('path2?callback=1');
         });
     });
     it('should call wrapUrl in script.src.setter', function() {