Merge pull request #150 from chingu-x/refactor/add_response_code_to_f…

…eature_delete

Introduce DeleteFeatureResponse and update deleteFeature method with a status code and a message

CHANGELOG.md

@@ -52,6 +52,7 @@ Another example [here](https://co-pilot.dev/changelog)
 - Update test github actions workflow with timeout [#143](https://github.com/chingu-x/chingu-dashboard-be/pull/143)
 - Refractor of all form title reference to use values from formTitle.ts [#145](https://github.com/chingu-x/chingu-dashboard-be/pull/145)
 - Update/Add more form input types [#146](https://github.com/chingu-x/chingu-dashboard-be/pull/146)
+- Update the deleteFeature method to use a DeleteFeatureResponse and return an object with a successful status and a message [#150](https://github.com/chingu-x/chingu-dashboard-be/pull/150)
 
 ### Fixed
 

src/features/features.controller.ts

@@ -33,6 +33,7 @@ import {
     FeatureCategoriesResponse,
     ExtendedFeaturesResponse,
     FeatureResponse,
+    DeleteFeatureResponse,
 } from "./features.response";
 import { CustomRequest } from "../global/types/CustomRequest";
 
@@ -256,6 +257,7 @@ export class FeaturesController {
     @ApiResponse({
         status: HttpStatus.OK,
         description: "Successfully deleted feature.",
+        type: DeleteFeatureResponse,
     })
     //Can only delete if loggedIn userId mataches addedBy userId
     @Delete("/features/:featureId")

src/features/features.response.ts

@@ -95,3 +95,11 @@ export class ExtendedFeaturesResponse {
     @ApiProperty()
     addedBy: AddedBY;
 }
+
+export class DeleteFeatureResponse {
+    @ApiProperty({ example: "The feature was deleted successfully" })
+    message: string;
+
+    @ApiProperty({ example: 200 })
+    statusCode: number;
+}

src/features/features.service.ts

@@ -369,6 +369,11 @@ export class FeaturesService {
             throw new NotFoundException(
                 `FeatureId (id: ${featureId}) does not exist.`,
             );
+        } else {
+            return {
+                message: "Feature deleted successfully",
+                status: 200,
+            };
         }
     }