Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sprints test #113

Merged
merged 32 commits into from
Mar 17, 2024
Merged

Feature/sprints test #113

merged 32 commits into from
Mar 17, 2024

Conversation

JoshuaHinman
Copy link
Contributor

Description

  • Added tests for all sprints routes
  • Added jest-extended dependency to provide expect.toBeOneOf() and other useful functions

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

yarn test:e2e sprints

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

Copy link
Collaborator

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thorough tests, all passed locally here. thanks!
just need to resolve that changelog conflict

siasktv
siasktv previously approved these changes Mar 8, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good structured tests but maybe label the test suites and specs to convey clearer intention of each unit test. I have added some suggestions for the describe and it blocks. I think it would make it easier for new developers to understand the intention of the unit tests.

I found this unit testing style guide that could help us keep a consist style to the tests.

test/sprints.e2e-spec.ts Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
JoshuaHinman and others added 6 commits March 10, 2024 17:42
Co-authored-by: timDeHof <ttdehof@gmail.com>
Co-authored-by: timDeHof <ttdehof@gmail.com>
Co-authored-by: timDeHof <ttdehof@gmail.com>
Co-authored-by: timDeHof <ttdehof@gmail.com>
Co-authored-by: timDeHof <ttdehof@gmail.com>
Co-authored-by: timDeHof <ttdehof@gmail.com>
@JoshuaHinman JoshuaHinman marked this pull request as draft March 11, 2024 02:31
@JoshuaHinman JoshuaHinman marked this pull request as ready for review March 13, 2024 20:37
cherylli
cherylli previously approved these changes Mar 15, 2024
@cherylli cherylli requested review from timDeHof and siasktv and removed request for Piero7210 March 15, 2024 03:34
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking great. I have spotted a couple of it statements that could be written in a way that newcomers could understand the tests better.

test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
test/sprints.e2e-spec.ts Outdated Show resolved Hide resolved
Co-authored-by: timDeHof <this.is.tim.dehof@gmail.com>
JoshuaHinman and others added 9 commits March 15, 2024 16:40
Co-authored-by: timDeHof <this.is.tim.dehof@gmail.com>
Co-authored-by: timDeHof <this.is.tim.dehof@gmail.com>
Co-authored-by: timDeHof <this.is.tim.dehof@gmail.com>
Co-authored-by: timDeHof <this.is.tim.dehof@gmail.com>
Co-authored-by: timDeHof <this.is.tim.dehof@gmail.com>
Co-authored-by: timDeHof <this.is.tim.dehof@gmail.com>
Co-authored-by: timDeHof <this.is.tim.dehof@gmail.com>
Co-authored-by: timDeHof <this.is.tim.dehof@gmail.com>
Co-authored-by: timDeHof <this.is.tim.dehof@gmail.com>
@JoshuaHinman JoshuaHinman marked this pull request as ready for review March 15, 2024 23:45
Copy link
Collaborator

@curtwl curtwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JoshuaHinman JoshuaHinman merged commit d84cece into dev Mar 17, 2024
1 check passed
@JoshuaHinman JoshuaHinman deleted the feature/sprints-test branch March 17, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants