Features/forms response

[siasktv]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue link

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature updates / changes
• Tests
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

yarn test:e2e forms

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have updated the change log

[cherylli]

hi, I get this response for sprints

which is not the desired response, refering to trello, we want something like this

[timDeHof]

I think the i at 'line 56 in form.service.ts' should be change to something more descriptive to make it easier to read.

[cherylli]

not sure if this is ready for review again since I see a new push but no comments with it.

There are still a few issues

• subquestions are also appeared under questions, e.g. question id 18 is appeared under both. could you please remove them from questions
• is it possible to hide subquestions when there's no subquestions? "subQuestions": []
• will also need to update the sample response on swagger

[cherylli]

marking this as draft as changes are required

[siasktv]

not sure if this is ready for review again since I see a new push but no comments with it.

There are still a few issues

• subquestions are also appeared under questions, e.g. question id 18 is appeared under both. could you please remove them from questions
• is it possible to hide subquestions when there's no subquestions? "subQuestions": []
• will also need to update the sample response on swagger

I think now is ready for review :)

[cherylli]

subQuestion actual responses don't match swagger example

subQuestions select needs more detail

[cherylli]

thanks, just looked at the code quickly before bed, will test it in action tomorrow 😊

[cherylli]

thanks, tested on swagger, everything works and all existing tests passed

[cherylli]

• will also need to update the sample response on swagger

it seems the swagger sample response doesn't match the actual response

[siasktv]

Hi @cherylli I checked swagger sample response and it seems it matches with the response. I couldn't find the error, could you please be more specific?

[cherylli]

thanks. it looks fine now. I must be looking at an older version sorry

[curtwl]

Looks good!

[timDeHof]

great job! All tests passed