Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/techs select redo #125

Merged
merged 1 commit into from
Mar 30, 2024
Merged

feature/techs select redo #125

merged 1 commit into from
Mar 30, 2024

Conversation

JoshuaHinman
Copy link
Contributor

Description

This is a re-submission of the tech selections endpoint PR, on a fresh branch with recent updates included. Previous issues should be addressed.
To apply the database changes in this PR, run yarn migrate and yarn push

This PR adds a new endpoint voyages/teams/{teamId}/techs/selections, allowing teams to designate tech stack items as "Selected" within their categories. It enforces a maximum of 3 selections per category, defined by const MAX_SELECTION_COUNT.

The teamTechStackItem model has been updated with Boolean value isSelected.

There are e2e test for the following responses:
-200 successful update
-400 max selections per category exceeded
-400 invalid teamid
-401 unauthorized- uses old JWT test

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This has been tested in swagger and with yarn test:e2e techs

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@JoshuaHinman JoshuaHinman changed the title adding tech select files to fresh branch feature/techs select redo Mar 29, 2024
Copy link
Collaborator

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! working as intended, all tests passed!

Copy link
Collaborator

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!! Unit and e2e tests passed. also swagger works too.

@JoshuaHinman JoshuaHinman merged commit 3f243f2 into dev Mar 30, 2024
1 check passed
@JoshuaHinman JoshuaHinman deleted the feature/techs-select branch March 30, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants