Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POST checkin form endpoint #126

Merged
merged 28 commits into from
Apr 3, 2024
Merged

Conversation

cherylli
Copy link
Collaborator

@cherylli cherylli commented Mar 29, 2024

Description

Added POST endpoint for check in form submissions

  • populate sprint check in submission form (seed)
  • update schema for checkin submission
  • add endpoints to save responses to the database
  • add seed data for a few sample responses
  • add e2e tests for the new endpoint(s)

Changes

  • updated sprints e2e tests
  • removed unique (questionId + responseId) from response, and updated meeting form create/update
  • moved a few things to global service as they will be used for other form submissions
  • added formTitles for mapping

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@cherylli cherylli self-assigned this Mar 29, 2024
@cherylli cherylli marked this pull request as ready for review April 1, 2024 13:44
@cherylli cherylli changed the title [Draft] Add POST checkin form endpoint Add POST checkin form endpoint Apr 1, 2024
@cherylli cherylli requested a review from timDeHof April 1, 2024 13:44
Copy link
Contributor

@siasktv siasktv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to run the tests but I'm getting this error:
image
I already run prisma db pull but somehow my schema.prisma has not being updated.

@cherylli
Copy link
Collaborator Author

cherylli commented Apr 1, 2024

I tried to run the tests but I'm getting this error: image I already run prisma db pull but somehow my schema.prisma has not being updated.

you need db push not db pull

curtwl
curtwl previously approved these changes Apr 2, 2024
Copy link
Collaborator

@curtwl curtwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Re: "do we need to check if sprintID is a reasonable sprint Id?", is that not being automatically populated in the form based on the date?

@cherylli
Copy link
Collaborator Author

cherylli commented Apr 2, 2024

LGTM. Re: "do we need to check if sprintID is a reasonable sprint Id?", is that not being automatically populated in the form based on the date?

no, atm we insert sprint id and teamMemberId, so we rely on frontend giving the right sprint id. although it's not really a huge issue as there's a createdAt date

timDeHof
timDeHof previously approved these changes Apr 3, 2024
Copy link
Collaborator

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Had an issues when running e2e tests that was caused by some of latest changes not able to pushed. but after that fix, all tests passed!

@cherylli cherylli requested review from curtwl and siasktv April 3, 2024 01:27
@cherylli cherylli requested a review from timDeHof April 3, 2024 02:31
@cherylli cherylli merged commit c843cf1 into dev Apr 3, 2024
1 check passed
@cherylli cherylli deleted the feature/checkin-form-endpoints branch April 3, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants