Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Resources GET response, added user id value #129

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

JoshuaHinman
Copy link
Contributor

Description

This PR modifies the return body of GET voyages/teams/{teamId}/resources, adding the user id value to the addedBy property.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested in swagger
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

cherylli
cherylli previously approved these changes Mar 30, 2024
siasktv
siasktv previously approved these changes Apr 1, 2024
curtwl
curtwl previously approved these changes Apr 1, 2024
Copy link
Collaborator

@curtwl curtwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoshuaHinman JoshuaHinman dismissed stale reviews from curtwl, siasktv, and cherylli via 0c700a1 April 2, 2024 23:59
@cherylli cherylli merged commit a97e749 into dev Apr 3, 2024
1 check passed
@cherylli cherylli deleted the fix/resources-response branch April 3, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants