Feature/populate voyage submission form #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stants/formTitles to improve code readability and maintainability The import statement has been added to import the FormTitles constant from the src/global/constants/formTitles module. This change improves code readability and maintainability by using a constant instead of a hard-coded string for the title of the check-in form.
…itles to improve maintainability The title field in the solo-project.ts file has been updated to use the constant FormTitles.soloProjectSubmission instead of the hard-coded string "Solo Project Submission Form". This change improves maintainability by centralizing the form title in a separate file and allows for easier updates in the future.
…constant from formTitles The title of the voyage application form has been updated to use the constant `FormTitles.voyageApplication` from the `formTitles` module. This improves maintainability and ensures consistency across the application.
… readability and maintainability fix(forms): update title of a form to use FormTitles.sprintPlanning constant for consistency and easier maintenance The import statement has been added to import the FormTitles constant from the global constants file. This improves code readability and maintainability by using a constant instead of a hard-coded string. The title of a form has been updated to use the FormTitles.sprintPlanning constant instead of a hard-coded string. This change improves consistency and makes it easier to update the title in the future.
A new form title "Voyage Submission Form" has been added to the FormTitles constant. This allows for better organization and clarity when referencing the Voyage Submission Form in the codebase.
…roject submission form The new file `projectsubmission.ts` contains a seed function `populateVoyageSubmissionForm` that creates a form in the database for submitting and sharing finished Chingu projects. The form includes various questions such as the project name, description, Github repo link, deployed project link, project showcase video link (optional), positive aspects of the experience (optional), comments on the experience (optional), and a rating scale for suggesting Chingu to others. This seed file allows for easy population of the Voyage project submission form in the database.
…submission.ts' for better understanding
…jectSubmission for clarity The form title for the voyageSubmission form has been updated to voyageProjectSubmission to provide more clarity and accurately reflect the purpose of the form.
…orm seed The CHANGELOG.md file has been updated to include an entry for the addition of a voyage project submission form seed. This seed was added as part of pull request #131.
siasktv
previously approved these changes
Apr 11, 2024
|
@siasktv did you run |
The import paths for the FormTitles module in the seed files have been updated to reflect the correct file location. The previous import paths were incorrect and caused errors when running the seed scripts. This change ensures that the seed files can access the FormTitles module correctly and populate the forms with the correct data.
Sorry, it was a mistake on my part. I didn't have the correct import path for |
|
I ran db seed but it wasn't populating the database I think the function wasn't called |
…ed data The voyage project submission form is added to the list of forms to be populated in the seed data. This form allows users to submit their project details for a voyage. The form includes fields for project description, Github repo link, deployed project link, project showcase video link, positive aspects of the experience, and any additional comments or feedback. This form is necessary to collect project information from users applying for a voyage.
yes, sorry about that. I forgot to add it to the forms |
cherylli
approved these changes
Apr 11, 2024
JoshuaHinman
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a series of changes aimed at enhancing the codebase's maintainability, readability, and overall organization. Specifically, it focuses on the standardization of form titles and the introduction of a new form submission seed. Below is a summary of the key modifications and their impact on the project:
Imported the
FormTitlesconstants across various modules (checkinform.ts,solo-project.ts,voyage-app.ts, and forms) to replace hard-coded strings with constants. This will improve the readability and maintainability of the code by centralizing form titles in one location, while ensuring consistency across the application.Introduced a seed file
voyage-project-submission.tsfor the 'Voyage Project Submission form. This file contains apopulateVoyageSubmissionForm` function that facilitates the creations and population of a new form in the database. This form is designed for submitting and sharing finished Chingu projects and includes fields for project details, experience feedback, and a rating scale for recommending Chingu to othersIssue link
Fixes # (issue)
Type of change
How Has This Been Tested?
run the script
yarn seedto verify that there isn't any problems in the form that are usingFormTiltle's constants. Then run the usual unit and e2e tests.Checklist: