Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CASL for access control #141

Merged
merged 24 commits into from
May 6, 2024
Merged

Implement CASL for access control #141

merged 24 commits into from
May 6, 2024

Conversation

cherylli
Copy link
Collaborator

@cherylli cherylli commented Apr 29, 2024

Description

Implemented CASL for access control, replacing @ROLE, and @Permission. Also updated ideation e2e tests to match the newer e2e tests, and updated readme.

More permissions will have to be added, this PR just replaces the routes with roles/permission based control.

Some extra stuff on confluence:
https://suwanna.atlassian.net/wiki/spaces/SD/pages/76349451/CASL

Issue link

No issue, this is in prepartion for adding more permissions https://app.clickup.com/t/86azr0q42

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested with swagger, unit tests and e2e tests
image
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

Copy link
Collaborator

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! I like how readable abilities are.

Copy link
Collaborator

@curtwl curtwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cherylli cherylli merged commit 709a6aa into dev May 6, 2024
1 check passed
@cherylli cherylli deleted the auth/casl-v2 branch May 6, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants