-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: e2e test for teams #162
Conversation
…into test/e2e-test-for-teams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just need to add 403 tests for non admin users for some routes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests passed. The test file is well-structured and follows good practices for e2e testing in Nestjs. However, I added a few suggestions to the code that could improve the code quality.
be80256
to
05c4e1b
Compare
05c4e1b
to
f8cb47d
Compare
…dashboard-be into test/e2e-test-for-teams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, All tests passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests passed and code looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran all the tests, all good. Thanks for adding the 403
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the tests passed!
Description
Issue link
Fixes # (issue)
Type of change
How Has This Been Tested?
Tested with
yarn test:docker
Checklist: