Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: e2e test for teams #162

Merged
merged 14 commits into from
Jun 12, 2024
Merged

Test: e2e test for teams #162

merged 14 commits into from
Jun 12, 2024

Conversation

Ajen07
Copy link
Collaborator

@Ajen07 Ajen07 commented Jun 7, 2024

Description

  • Added e2e tests for Teams controller

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested with yarn test:docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@Ajen07 Ajen07 self-assigned this Jun 7, 2024
@Ajen07 Ajen07 changed the title Test/e2e test for teams Test: e2e test for teams Jun 7, 2024
@Ajen07 Ajen07 requested review from cherylli, timDeHof, JoshuaHinman and curtwl and removed request for cherylli June 7, 2024 15:55
Copy link
Collaborator

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just need to add 403 tests for non admin users for some routes

src/teams/teams.service.ts Outdated Show resolved Hide resolved
test/teams.e2e-spec.ts Show resolved Hide resolved
test/teams.e2e-spec.ts Outdated Show resolved Hide resolved
test/teams.e2e-spec.ts Outdated Show resolved Hide resolved
test/teams.e2e-spec.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed. The test file is well-structured and follows good practices for e2e testing in Nestjs. However, I added a few suggestions to the code that could improve the code quality.

@Ajen07 Ajen07 requested review from cherylli and timDeHof June 9, 2024 06:26
@Ajen07 Ajen07 marked this pull request as draft June 9, 2024 06:32
@Ajen07 Ajen07 marked this pull request as ready for review June 9, 2024 07:39
timDeHof
timDeHof previously approved these changes Jun 9, 2024
Copy link
Collaborator

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, All tests passed

JoshuaHinman
JoshuaHinman previously approved these changes Jun 9, 2024
Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed and code looks great

@Ajen07 Ajen07 dismissed stale reviews from JoshuaHinman and timDeHof via 7c3ad8e June 10, 2024 03:12
Copy link
Collaborator

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran all the tests, all good. Thanks for adding the 403

Copy link
Collaborator

@timDeHof timDeHof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests passed!

@Ajen07 Ajen07 merged commit dd05a09 into dev Jun 12, 2024
1 check passed
@Ajen07 Ajen07 deleted the test/e2e-test-for-teams branch June 12, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants