-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/checkin form endpoints #166
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job ! All the changes looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is it possible also populate the responses? In the response I can only see
responseGroupId:1
, this doesn't really allow the admin to see the responses when they pull the submission.
===========
- I also see something weird, I get the same result regardless of what sprintNumber I put, I always get sprintId: 1 (there's only 1 check in form in my database for sprint 1)
=============
- when
voyageNumber
is not given, sprint Number should not work, as we don't know sprint x of what voyage, I'm getting records for sprintId 2. Please note that sprint number and sprint id are different.
Description
Retrieves check-in form responses given a sprintNumber, voyageId, userId, or teamId query param. If multiple are provided, just the first is taken instead of giving an error.
Issue link
https://app.clickup.com/t/86azuu2yc
Fixes # (issue)
Type of change
How Has This Been Tested?
New tests and manual verification with Swagger that errors are handled as expected.
Checklist: