Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/checkin form endpoints #166

Open
wants to merge 23 commits into
base: dev
Choose a base branch
from
Open

Conversation

curtwl
Copy link
Collaborator

@curtwl curtwl commented Jun 16, 2024

Description

Retrieves check-in form responses given a sprintNumber, voyageId, userId, or teamId query param. If multiple are provided, just the first is taken instead of giving an error.

Issue link

https://app.clickup.com/t/86azuu2yc

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

New tests and manual verification with Swagger that errors are handled as expected.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

@curtwl curtwl marked this pull request as ready for review June 17, 2024 13:29
src/sprints/sprints.response.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I ran unit tests, these lines in sprints.contoller threw errors:
image
I changed the paths form src/ to ../ to get them working

@curtwl
Copy link
Collaborator Author

curtwl commented Jun 22, 2024

When I ran unit tests, these lines in sprints.contoller threw errors: image I changed the paths form src/ to ../ to get them working

Strange, both ways work for me... I've updated them to use ../ instead of src/

@curtwl curtwl closed this Jun 22, 2024
@curtwl curtwl reopened this Jun 22, 2024
Copy link
Collaborator

@Ajen07 Ajen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job ! All the changes looks good.

Copy link
Collaborator

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is it possible also populate the responses? In the response I can only see responseGroupId:1, this doesn't really allow the admin to see the responses when they pull the submission.

===========

  1. I also see something weird, I get the same result regardless of what sprintNumber I put, I always get sprintId: 1 (there's only 1 check in form in my database for sprint 1)

image

=============

  1. when voyageNumber is not given, sprint Number should not work, as we don't know sprint x of what voyage, I'm getting records for sprintId 2. Please note that sprint number and sprint id are different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants