Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add more checkin form and updates base checkin form questions #167

Merged
merged 11 commits into from
Jun 29, 2024

Conversation

timDeHof
Copy link
Collaborator

@timDeHof timDeHof commented Jun 16, 2024

Description

This PR add checkin forms that ask team members for feedback on Product Owners and scrum masters that are on their teams.

  • Two new form titles, "Sprint Check-in (Product Owner)" and "Sprint Check-in (Scrum Master)", have been added to the FormTitles constant.
  • Two new forms, checkinformPO.ts and checkinformSM.ts, have been added to the prisma/seed/forms folder.

Issue link

Fixes # add more checkin forms

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature updates / changes
  • Tests
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I tested this by:

  1. run yarn seed to populate the database

  2. run yarn studio and look in the form for "Sprint Check-in (Product Owner)" and "Sprint Check-in (Scrum Master)" in the title section
    Screenshot 2024-06-17 at 8 42 09 PM

  3. in the form, the "Sprint Check-in (Product Owner)" form should show 2 questions and "Sprint Check-in (Scrum Master)" should show 4 questions.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the change log

…ct Owner and Scrum Master

Two new form titles, "Sprint Check-in (Product Owner)" and "Sprint Check-in (Scrum Master)", have been added to the FormTitles constant. These titles are used to identify specific forms related to the sprint check-in process for the Product Owner and Scrum Master roles.
@timDeHof timDeHof self-assigned this Jun 16, 2024
Two new files, `checkinformPO.ts` and `checkinformSM.ts`, have been added to the `prisma/seed/forms` directory. These files contain functions to populate the database with check-in forms for the Product Owner and Scrum Master roles respectively.

The `populateCheckinFormPO` function creates a check-in form for the Product Owner role. It includes questions about the Product Owner's strengths and allows for additional feedback. The form is associated with the "voyage member" form type.

The `populateCheckinFormSM` function creates a check-in form for the Scrum Master role. It includes questions about Scrum training, issue resolution, event management, and allows for additional feedback. The form is also associated with the "voyage member" form type.

These forms are added to gather feedback and insights from team members about the Product Owner and Scrum Master roles during sprints.

Note: The `FormTitles` constant is imported from the `src/global/constants/formTitles` module to provide consistent and predefined titles for the forms.

The addition of these check-in forms enhances the feedback and communication process within the team, allowing for better collaboration and improvement of the Product Owner and Scrum Master roles.
… teams' PO and SM

The populateFormsAndResponses function now includes calls to populateCheckinFormPO and populateCheckinFormSM, which are responsible for populating checkin forms specifically for teams with product owners and scrum masters. This allows for more comprehensive form population and better support for different roles within the application.
The description of the checkin form for product owners has been updated to provide more context and guidance to the users. The new description emphasizes the importance of Agile/Scrum in a Voyage and requests feedback on how the users are following it and how their Product Owner and Scrum Master are supporting their team.
…xt and guidance

The description of the checkinFormSM has been updated to provide more context and guidance to the users. This will help them understand the purpose of the form and what kind of feedback is expected from them.
…r product owner and scrum master

The CHANGELOG.md file has been updated to include an entry for the addition of weekly sprint checkin forms for the product owner and scrum master. This change was made in pull request #167.
@timDeHof timDeHof marked this pull request as ready for review June 18, 2024 00:58
JoshuaHinman
JoshuaHinman previously approved these changes Jun 19, 2024
Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seeded and verified the changes in Studio - great work!

…better clarity and relevance

chore(checkinform.ts): reorganize the order of the questions in the check-in form
The check-in form questions and options have been updated to provide clearer and more relevant information. The "How did you communicate with your team this past week?" question has been changed to "Which Scrum events did your team hold in the prior sprint? Please answer 'yes' to any you did even if they were combined in another meeting." to gather more specific information about the team's Scrum events. The options for this question have also been updated to reflect common Scrum events.

The "Did you contribute to the project for your team this past week?" question has been changed to "How would you rate your team's progress right now?" to gather information about the team's progress. The options for this question have been updated to reflect different progress levels.

The "How did you communicate with your team this past week?" question has been changed to "How did you communicate with your team this past week?" to gather information about the team's communication methods. The options for this question have been updated to reflect different communication methods.

The "What topics did your meetings cover this week? (Select all that apply)" question has been changed to "Did you contribute to the project this past week by designing, coding, or testing your teams app?" to gather information about the team's contributions. The options for this question have been updated to reflect different contribution types.

The order of the questions in the check-in form has been reorganized for better flow and clarity.
A new question has been added to the check-in form for Product Owners. The question asks if a Product Owner has been assigned to the team. The question is of type "radio" and has three options: "Yes", "No", and "I'm the Product Owner". The question is required to be answered. The question has been added as the first question in the form.

Additionally, the order of an existing question has been changed. The question that was previously at order 2 is now at order 3.

These changes have been made to improve the check-in form for Product Owners and gather more relevant information during the check-in process.
A new question has been added to the checkinformSM form. The question asks if the team has a Scrum Master. The question is of type "radio" and is required to be answered. The question has three options: "Yes", "No", and "I'm the Scrum Master". This addition enhances the checkinformSM form by gathering information about the presence of a Scrum Master in the team.
…roduct Owner assignment and update order of remaining questions

The question about whether a Product Owner has been assigned to the team has been removed as it is handled in the database. The order of the remaining questions has been updated accordingly. This change improves the clarity and relevance of the check-in form for Product Owners.
cherylli
cherylli previously approved these changes Jun 24, 2024
Copy link
Collaborator

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, everything looks good. prisma db seed was working and all tests passed

Copy link
Contributor

@JoshuaHinman JoshuaHinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeded and verified changes in database - looks good

Copy link
Collaborator

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry forgot to re-approve this after merge

@timDeHof timDeHof merged commit cb5e56e into dev Jun 29, 2024
1 check passed
@timDeHof timDeHof deleted the feat/add_more_checkin_forms branch June 29, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants