-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add refresh token #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenny-alexander
previously approved these changes
Jan 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I did various tests like:
- Access token and refresh token were granted after successful login.
- Access token was removed from cookies after 15 minutes.
- Refresh token was successfully granted after access token expires.
- I tampered with refresh token and when 'refresh' endpoint was invoked, it failed (as expected).
- Access token and refresh token were removed from cookies after successful logout & refreshToken set to null in database.
cherylli
commented
Jan 20, 2024
https://github.com/chingu-x/chingu-dashboard-be/pull/78/files#r1460185576 |
jenny-alexander
approved these changes
Jan 20, 2024
curtwl
approved these changes
Jan 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@Public
decoratorRefresh token will have 7 day expiry, while access token will expire in 15mins (I think access tokens can probably have a longer expiry)
Please add 2 new environment Variables
AT_SECRET
RT_SECRET
JWT_SECRET can be removed
Issue link
Fixes # (issue)
Type of change
How Has This Been Tested?
Tested locally
Checklist: