Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind eslint #142

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Tailwind eslint #142

merged 4 commits into from
Jun 5, 2024

Conversation

Dan-Y-Ko
Copy link
Collaborator

@Dan-Y-Ko Dan-Y-Ko commented Jun 1, 2024

Description

Added tailwind eslint and prettier setup. Also fixed all the linting issues that popped up as a result. This will make it so we get linting for our tailwind classes and also order the classes in a consistent way with prettier.

There were a lot of invalid tailwind classes, so I did my best to replicate the intended styles and compared to the previous version (before the edits made in this branch) and it looks the same, but it'd be good idea to check that over again too.

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Jun 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 8:09am

JaneMoroz
JaneMoroz previously approved these changes Jun 4, 2024
Copy link
Collaborator

@JaneMoroz JaneMoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, except for TechStackCard, but I think it's gonna be fixed in later techStack PRs

@Dan-Y-Ko Dan-Y-Ko merged commit 24212c2 into dev Jun 5, 2024
3 checks passed
@Dan-Y-Ko Dan-Y-Ko deleted the fix/tailwind-eslint branch June 5, 2024 14:09
Dan-Y-Ko added a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants