Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: responsive layout for the tech stack container #31

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

timothyrusso
Copy link
Collaborator

@timothyrusso timothyrusso commented Sep 25, 2023

Description

Responsive layout for the Tech Stack component.
Now we will have 2 columns for the resolution under 1920px of width, and 3 columns for above.
Simplified the code of the component and removed the getJustifyClass method.
The horizontal gap for the grid cells will be a little bit different from the one on Figma on some breakpoints, because now we have a width 100% defined in a previous pull request.

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 7:45pm

Copy link
Collaborator

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Tim,
I am still getting 2 columns in 1920x1080 monitor: https://i.imgur.com/wjybRze.png

@timothyrusso
Copy link
Collaborator Author

Hey Tim, I am still getting 2 columns in 1920x1080 monitor: https://i.imgur.com/wjybRze.png

@Dan-Y-Ko In my monitor I saw 3 columns on 1920x1080:
image

Also because there is a check here for the minimum width:

<ul className="grid grid-cols-2 min-[1920px]:grid-cols-3 gap-10 place-items-center">

@Dan-Y-Ko
Copy link
Collaborator

Dan-Y-Ko commented Sep 27, 2023

Hey Tim, I am still getting 2 columns in 1920x1080 monitor: https://i.imgur.com/wjybRze.png

@Dan-Y-Ko In my monitor I saw 3 columns on 1920x1080: image

Also because there is a check here for the minimum width:

<ul className="grid grid-cols-2 min-[1920px]:grid-cols-3 gap-10 place-items-center">

I'm not sure what's going on here. I am definitely on a 1920x1080 monitor. https://i.imgur.com/HvI0fyO.png at 100% scaling: https://i.imgur.com/4QmSceJ.png. If I set it to 90%, it goes to 3 columns.

Ok I figured it out. It's a browser issue. Do you know of a quick solution to handle an edge case with Edge browser? If not, we can just merge this.

Nvm, I looked into it. It's a useless feature they added into the Edge browser to add margins on the outside and with rounded corners. I think we can disregard this as there doesn't really seem to be any solutions atm.

Copy link
Collaborator

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

good job :)

@Dan-Y-Ko Dan-Y-Ko merged commit 24fc4fa into dev Sep 27, 2023
3 checks passed
@Dan-Y-Ko Dan-Y-Ko deleted the feature/responsive-tech-stack branch September 27, 2023 19:57
Dan-Y-Ko added a commit that referenced this pull request Jul 9, 2024
feat: responsive layout for the tech stack container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants