-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: responsive layout for the tech stack container #31
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Tim,
I am still getting 2 columns in 1920x1080 monitor: https://i.imgur.com/wjybRze.png
@Dan-Y-Ko In my monitor I saw 3 columns on 1920x1080: Also because there is a check here for the minimum width:
|
I'm not sure what's going on here. I am definitely on a 1920x1080 monitor. https://i.imgur.com/HvI0fyO.png at 100% scaling: https://i.imgur.com/4QmSceJ.png. If I set it to 90%, it goes to 3 columns. Ok I figured it out. It's a browser issue. Do you know of a quick solution to handle an edge case with Edge browser? If not, we can just merge this. Nvm, I looked into it. It's a useless feature they added into the Edge browser to add margins on the outside and with rounded corners. I think we can disregard this as there doesn't really seem to be any solutions atm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
good job :)
feat: responsive layout for the tech stack container
Description
Responsive layout for the Tech Stack component.
Now we will have 2 columns for the resolution under 1920px of width, and 3 columns for above.
Simplified the code of the component and removed the
getJustifyClass
method.The horizontal gap for the grid cells will be a little bit different from the one on Figma on some breakpoints, because now we have a width 100% defined in a previous pull request.
Issue link
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: