-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial CICD settings; add theme colors to DaisyUI #4
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this was meant to be done in a separate ticket, but this is fine. We can update it later if needed. I need to review with Eury on what exactly should be set for this. Not just this but also things like the typography, also clean up the figma on what theme should be used for each component because currently it is not set.
Yeah, I only put it in there as when I work on the Nav I'll be using the colours anyway. Would be good to know the fonts. We can just lift that from Figma though at least for the time being. I think it'd make sense to make that one of the first things we do. |
Basic CICD setup:
• Running ESlint, Jest and Cypress test
• Creating a preview deploy for Vercel (when testing in a local repo it didn't generate the PR comment with a link. It should do that automatically, so will test here)
Set Chingu core colors from Figma into the DaisyUI theme for ease of use and conformity.
Set Cypress config to not record video or screenshots by default