Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial CICD settings; add theme colors to DaisyUI #4

Merged
merged 8 commits into from
Aug 27, 2023
Merged

Initial CICD settings; add theme colors to DaisyUI #4

merged 8 commits into from
Aug 27, 2023

Conversation

marktlinn
Copy link
Collaborator

  • Basic CICD setup:
    • Running ESlint, Jest and Cypress test
    • Creating a preview deploy for Vercel (when testing in a local repo it didn't generate the PR comment with a link. It should do that automatically, so will test here)

  • Set Chingu core colors from Figma into the DaisyUI theme for ease of use and conformity.

  • Set Cypress config to not record video or screenshots by default

@vercel

This comment was marked as outdated.

Copy link
Collaborator

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this was meant to be done in a separate ticket, but this is fine. We can update it later if needed. I need to review with Eury on what exactly should be set for this. Not just this but also things like the typography, also clean up the figma on what theme should be used for each component because currently it is not set.

@marktlinn
Copy link
Collaborator Author

marktlinn commented Aug 25, 2023

Ah, this was meant to be done in a separate ticket, but this is fine. We can update it later if needed. I need to review with Eury on what exactly should be set for this. Not just this but also things like the typography, also clean up the figma on what theme should be used for each component because currently it is not set.

Yeah, I only put it in there as when I work on the Nav I'll be using the colours anyway. Would be good to know the fonts. We can just lift that from Figma though at least for the time being. I think it'd make sense to make that one of the first things we do.

@marktlinn marktlinn changed the title add: initial CICD settings; add them colors to DaisyUI Initial CICD settings; add them colors to DaisyUI Aug 26, 2023
@marktlinn marktlinn changed the title Initial CICD settings; add them colors to DaisyUI Initial CICD settings; add theme colors to DaisyUI Aug 26, 2023
@marktlinn marktlinn closed this Aug 26, 2023
@marktlinn marktlinn reopened this Aug 26, 2023
@github-actions
Copy link

github-actions bot commented Aug 26, 2023

@marktlinn marktlinn merged commit 2c7fc2f into dev Aug 27, 2023
2 of 3 checks passed
@marktlinn marktlinn deleted the CICD branch August 27, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants