Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why include log4j12 dependency? #3

Closed
spiritinlife opened this issue Dec 8, 2020 · 5 comments
Closed

Why include log4j12 dependency? #3

spiritinlife opened this issue Dec 8, 2020 · 5 comments
Projects
Pusher Client for Flutter

Comments

@spiritinlife
Copy link
Contributor

I am considering using this library, but i am not sure why is log4j12 used?
@spiritinlife
Copy link
Contributor Author

Also when minifyEnabled=true, i get Caused by: java.lang.ClassNotFoundException: Didn't find class "org.apache.log4j.Category" on path: DexPathList

@chinloyal chinloyal mentioned this issue Jan 20, 2021
Closed
@chinloyal
Copy link
Owner

The configuration for this is mentioned in the read me here It speaks to what to do if minifyEnabled is true

@spiritinlife
Copy link
Contributor Author

Yes I understand that, but how is log4j used in the plugin ? Is it necessary ?

@chinloyal
Copy link
Owner

I may have installed it for logging but I'm realizing that I had used android.util.Log instead so I may have installed log4j but forgot to remove it.

@chinloyal chinloyal added this to In progress in Pusher Client for Flutter Jan 21, 2021
@chinloyal
Copy link
Owner

I'll remove it

chinloyal added a commit that referenced this issue Jan 21, 2021
@chinloyal
v1.1.2: Removed log4j dependency #3
84201d2
@chinloyal chinloyal moved this from In progress to Done in Pusher Client for Flutter Jan 21, 2021
@heshesh2010 heshesh2010 mentioned this issue Apr 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Pusher Client for Flutter
Status: Done
Pusher Client for Flutter
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spiritinlife @chinloyal