-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ReferenceError in dist/esm/index.mjs
#892
Conversation
Fixed: ReferenceError: require is not defined in ES module scope, you can use import instead Removed require and add es6 import for `PropTypes`
Hello, @sakib412! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
Kudos, SonarCloud Quality Gate passed! |
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. Reviewers with knowledge related to these changes
Potential missing files from this Pull requestfiles commonly committed with a subset of this pr, but not committed this time. (click to collapse)
Committed file ranks(click to expand)57.54% [dist/esm/index.mjs] |
@@ -1,6 +1,7 @@ | |||
import * as React from 'react'; | |||
import PlyrJS from 'plyr'; | |||
import useAptor from 'react-aptor'; | |||
import PropTypes from 'prop-types'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to add prop-types, please add here https://github.com/chintan9/plyr-react/blob/master/src/index.tsx
Fixed: ReferenceError: require is not defined in ES module scope, you can use import instead
Removed require and add es6 import for
PropTypes