Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ReferenceError in dist/esm/index.mjs #892

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

sakib412
Copy link
Contributor

@sakib412 sakib412 commented Jul 7, 2022

Fixed: ReferenceError: require is not defined in ES module scope, you can use import instead

Removed require and add es6 import for PropTypes

Fixed:  ReferenceError: require is not defined in ES module scope, you can use import instead

Removed require and add es6 import for `PropTypes`
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jul 7, 2022
@sourcelevel-bot
Copy link

Hello, @sakib412! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vizipi
Copy link

vizipi bot commented Jul 7, 2022

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00 % Chintan Prajapati 3 1

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
dist/system/index.development.js75.00 %3 out of 4 times
dist/package.json75.00 %3 out of 4 times
dist/esm/index.js75.00 %3 out of 4 times
dist/umd/index.production.js75.00 %3 out of 4 times
dist/index.js75.00 %3 out of 4 times
dist/system/index.production.js75.00 %3 out of 4 times
dist/index.d.ts75.00 %3 out of 4 times
dist/esm/index.d.ts75.00 %3 out of 4 times
dist/umd/index.development.js75.00 %3 out of 4 times
dist/plyr.css50.00 %2 out of 4 times

Committed file ranks

(click to expand)
  • 57.54%[dist/esm/index.mjs]
  • @trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jul 21, 2022
    @chintan9 chintan9 self-requested a review July 21, 2022 20:04
    @chintan9 chintan9 mentioned this pull request Jul 21, 2022
    @@ -1,6 +1,7 @@
    import * as React from 'react';
    import PlyrJS from 'plyr';
    import useAptor from 'react-aptor';
    import PropTypes from 'prop-types';
    Copy link
    Owner

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    If you want to add prop-types, please add here https://github.com/chintan9/plyr-react/blob/master/src/index.tsx

    @chintan9 chintan9 merged commit c4f541a into chintan9:master Jul 21, 2022
    @trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Jul 21, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ✨ Merged Pull Request has been merged successfully size/XS
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    2 participants