Fix DB workings to use Laravel artisan commands #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. MySQL dumpfile no longer called - has been removed.
2. Artisan migrate and seed calls made in InstallController.
3. Bootstrap autoloader modified to return a new LARAVEL_START_...
value for each new process - needed to run tests in process isolation
4. Update install controller tests to reflect changes.
|
@CyberiaResurrection Thanks for solving the DB issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had downloaded 92five for my own use and had problems with database setup that blocked installation.
Judging by your issue tracker, I'm not the only one (for example, #101 (partly), #76, #102 ), so I've cleaned up and published local changes I had made.
I haven't tried breaking your big migration file out into its component parts - I was more focused on simply getting it working. I added basic tests so I could verify my changes still did what they were supposed to - are there any more tests you want me to add regarding my changes?
On two local machines of mine, php artisan migrate --seed and php artisan migrate:reset both run to completion with no errors.
92five also installs cleanly on both machines after these changes.