Fix for issue #532: SD Library compile error on MX1/MX2 #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also added __PIC32_PPS__ define and updated some files with it
* Also added __PIC32_PPS__ define and updated some files with it
Conflicts: hardware/pic32/libraries/SD/utility/Sd2PinMap.h
|
hey @chipkitbot, this is ok to test |
ricklon
added a commit
that referenced
this pull request
Aug 26, 2015
Fix for issue #532: SD Library compile error on MX1/MX2
EmbeddedMan
added a commit
to chipKIT32/chipKIT-core
that referenced
this pull request
Aug 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to go in and modify the SD library a bit more than I first thought. However, I cleaned a number of things up in there (like we were trying to do some saving/restoring of SPI interrupts on MAX32, UNO32, uC32 that didn't need to be done, references to SOFTWARE_SPI (we're always using software SPI in this library), etc.). I also added PIC32_PPS as a define we can use anywhere now to trigger code that only needs to exists for PPS parts.
This should all be merged over into chipKIT-core someday too.