Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings seems to not be applied #1

Closed
Tepee-me opened this issue Oct 26, 2013 · 12 comments

Comments

Projects
None yet
3 participants
@Tepee-me
Copy link

commented Oct 26, 2013

With final version 3.7 of wordpress just out, when I check "Permit Automatic Updates? ", and save the modifications, the option stay unselected after refresh.
And as I have choose "Permit Automatic Plugin Updates?", after refresh, it becomes gray.
It seems that options are not active. I have still 2 plugins waiting updating.

@georgestephanis

This comment has been minimized.

Copy link
Collaborator

commented Oct 26, 2013

I believe some of the filters may have changed names since I originally wrote this. Just merged a pull from @chipbennett, about to test and confirm.

@Tepee-me

This comment has been minimized.

Copy link
Author

commented Oct 26, 2013

I have tested his proposal.
Settings stay selected, so it seems OK for the remaining of the settings (I chose UP for plugins)...
For working automatic updating, I don't really know if settings are effective, because I don't have outdated plug-ins at the moment...
About that, do you know if there is a mail sent to the admin when automatic updating have been automaticly done for a plug-in ?

@Tepee-me Tepee-me closed this Oct 26, 2013

@Tepee-me Tepee-me reopened this Oct 26, 2013

@chipbennett

This comment has been minimized.

Copy link
Owner

commented Oct 26, 2013

Yes, the automatic update process does send an email following an update attempt of any type. The filter is 'auto_core_update_send_email'

Refer to Nacin's definitive post on automatic updates for more information.

@Tepee-me

This comment has been minimized.

Copy link
Author

commented Oct 26, 2013

Maybe it could be a good idea to propose this option too ?

@Tepee-me

This comment has been minimized.

Copy link
Author

commented Oct 26, 2013

Maybe it wouldn't be really necessary...

@chipbennett

This comment has been minimized.

Copy link
Owner

commented Oct 26, 2013

Let me take a look. It would be pretty easy to add. I'm thinking a global "enable emails", and then dependent options for each update type (core, theme, plugin, translation).

@chipbennett

This comment has been minimized.

Copy link
Owner

commented Oct 26, 2013

Going to be a bit trickier than I had hoped. It would be easy to filter by result type (success, failure, critical), but I think what would be useful would be to filter by update offer type (core, plugin, theme, translation). Trying to dig into the $core_update object to figure out the best way to accomplish that.

@Tepee-me

This comment has been minimized.

Copy link
Author

commented Oct 26, 2013

A only one selection "Receive summary email about automatic update performed" would be enough ?

@chipbennett

This comment has been minimized.

Copy link
Owner

commented Oct 26, 2013

A only one selection "Receive summary email about automatic update performed" would be enough ?

I've already got that added to my dev environment. Just trying to make it better. :)

@chipbennett

This comment has been minimized.

Copy link
Owner

commented Oct 26, 2013

Okay, so after looking further, it appears that emails are only sent for core updates. So, a single option it is.

@Tepee-me

This comment has been minimized.

Copy link
Author

commented Oct 26, 2013

It is a shame that we wouldn't be aware about plugin or themes updating...

@chipbennett

This comment has been minimized.

Copy link
Owner

commented Feb 7, 2014

Closing for now, since there's nothing more we can do at the moment.

@chipbennett chipbennett closed this Feb 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.