fix tests breaking if GMP not installed - will skip properly

chippyash · Sep 23, 2014 · b5367c0 · b5367c0
1 parent 6008ca8
commit b5367c0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -357,4 +357,6 @@ V2.0.0 Add GMP support
 
 V2.0.1 Additional gmp type checking
 
-V2.0.2 update Zend dependencies
+V2.0.2 update Zend dependencies
+
+V2.03 fix tests breaking if GMP not installed - will skip properly
diff --git a/test/src/chippyash/Type/Number/Complex/GMPComplexTypeFactoryTest.php b/test/src/chippyash/Type/Number/Complex/GMPComplexTypeFactoryTest.php
@@ -69,6 +69,7 @@ public function testCreateWithUnsupportedParamTypesThrowsException()
 
     /**
      * @dataProvider correctParamCombinations
+     * 
      */
     public function testCreateWithCorrectParamTypesReturnsComplexType($r, $i)
     {
@@ -77,8 +78,15 @@ public function testCreateWithCorrectParamTypesReturnsComplexType($r, $i)
 
     }
 
+    /**
+     * For some reason phpunit ignores the requires annotation at the class level
+     * - it seems to process data providers first
+     */
     public function correctParamCombinations()
     {
+        if (!extension_loaded('gmp')) {
+            return [[2,2]];
+        }
         return [
             //numeric int
             [2,2],