VeeR EL2 core is broken

[MikePopoloski]

Failing in all tools that do elaboration (slang, verilator) with errors like:

../../../third_party/cores/veer-el2/testbench/uvm/mem/hdl/dccm_monitor.sv:4:28: error: use of undeclared identifier 'uvm_monitor'; did you mean 'dccm_monitor'?
class dccm_monitor extends uvm_monitor;
                           ^~~~~~~~~~~
../../../third_party/cores/veer-el2/testbench/uvm/mem/hdl/dccm_monitor.sv:4:7: note: declared here
class dccm_monitor extends uvm_monitor;
      ^
../../../third_party/cores/veer-el2/testbench/uvm/mem/hdl/dccm_monitor.sv:10:3: error: unknown macro or compiler directive '`uvm_component_utils'
  `uvm_component_utils(dccm_monitor)
  ^

If a test is flat out broken for a long time it seems like it should either be fixed up or removed from the test suite.

[tgorochowik]

Hi Mike,

thanks for the report, we've disabled the UVM test for this core as it required a custom UVM branch anyway (it uses a custom branch anyway).

Some of the tools already pass this test (slang fails though).

[MikePopoloski]

After the UVM changes the slang failures look like this:

../../../third_party/cores/veer-el2/testbench/tb_top.sv:1304:16: error: cannot have multiple continuous assignments to variable 'dccm_wr_data_bank'
        assign el2_mem_export.dccm_wr_data_bank[i] = dccm_wr_fdata_bank[i][pt.DCCM_DATA_WIDTH-1:0];
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../third_party/cores/veer-el2/testbench/tb_top.sv:793:30: note: also assigned here
    .dccm_wr_data_bank      (el2_mem_export.dccm_wr_data_bank),
                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

These appear to be real errors to me, not sure why other tools are not catching this. I believe this is related to this other issue in your project's tracker: chipsalliance/Cores-VeeR-EL2#163