Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core dump Yosys AST bsg_strobe.json #1587

Closed
alaindargelas opened this issue Mar 17, 2023 · 3 comments
Closed

Core dump Yosys AST bsg_strobe.json #1587

alaindargelas opened this issue Mar 17, 2023 · 3 comments

Comments

@alaindargelas
Copy link
Collaborator

Test bsg_micro_designs/bsg_misc/bsg_strobe/bsg_strobe.json
yosys-uhdm-plugin-integration$ ./run_formal_verif.sh test=bsg_strobe.json

cd bsg_micro_designs/bsg_misc/bsg_strobe
~/yosys-uhdm-plugin-integration/image/bin/yosys -s ~/yosys-uhdm-plugin-integration/build/tests/bsg_strobe.json/surelog.ys

555556f43ac0]
              AST_IDENTIFIER </home/alain/yosys-uhdm-plugin-integration/bsg_micro_designs/bsg_misc/bsg_strobe/src/bsg_reduce.v:27.18-27.19> [0x555556f43c80] str='\i'
--- END OF AST DUMP ---

Program received signal SIGSEGV, Segmentation fault.
0x00005555557e9b8c in Yosys::AST::AstNode::simplify(bool, bool, bool, int, int, bool, bool) ()
(gdb) where
#0  0x00005555557e9b8c in Yosys::AST::AstNode::simplify(bool, bool, bool, int, int, bool, bool) ()
...
@wsipak
Copy link
Contributor

wsipak commented May 2, 2023

With the current version of the plugin (8bd3ecd) and the bsg_micro_designs suite that is introduced here: #1673, my observation is that the files in bsg_strobe.json test can be parsed in Yosys without errors.

Formal verification results in:

11. Executing EQUIV_MAKE pass (creating equiv checking module).
ERROR: Can't match gate port `init_val_r_i_gate' to a gold port.

However, I haven't encountered any segmentation fault when working with this test, so I expect the issue might have been solved already.

@hzeller
Copy link
Collaborator

hzeller commented May 2, 2023

Using the address sanitizer could detect some of these things early.

Looks like PR #913 works towards implementing #649 , but it got stalled.

@alaindargelas
Copy link
Collaborator Author

There is one core dump here:
https://chipsalliance.github.io/sv-tests-results/?v=uhdmyosys+black-parrot+bp_cce

probably the one in this case is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants