Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GitHub token to test #13

Merged
merged 1 commit into from Sep 23, 2021
Merged

Conversation

wsipak
Copy link
Contributor

@wsipak wsipak commented Sep 23, 2021

The test would fail because the default reporter is "github-pr-review" and there wasn't a token provided.
The reason I change the test, and not the code of the action, is because I assume that the correct usage of the action is to either:

  1. Use a reporter that requires the token ("github-pr-review") AND provide the token.
  2. Use a reporter that doesn't require the token (for example "local").

The workflow was successful here: https://github.com/antmicro/verible-linter-action/actions/runs/1266083502

@tgorochowik tgorochowik merged commit 32d95f4 into chipsalliance:main Sep 23, 2021
@tgorochowik tgorochowik deleted the wsip/fix_test branch September 23, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants