Panicking on for_each_mut_string

[Polish-Civil]

Hello, i've had an issue recently panicking on slice out of bounds, i think this line is the issue as it doesn't check this string value inside match statement before it's mutation.

I do not have the logs as i just lost them ;/

distant/distant-core/src/client/lsp/msg.rs

Line 304 in ea2e128

Value::String(s) => mutate(s),

[chipsenkbeil]

Hm, that call eventually triggers this:

distant/distant-core/src/client/lsp/msg.rs

Line 313 in ea2e128

s.replace_range(pos..old.len(), new);

I'm not available to test it yet, but I think I meant to write s.replace_range(pos..pos + old.len(), new);.

[Polish-Civil]

oh yeah pos + old.len() should do it too :)

unable to swap prefix old: [file:] new: [distant:] string: [Expands to the file name in which it was invoked.\n\nWith [`line!`] and [`column!`], these macros provide debugging information for\ndevelopers about the location within the source.\n\nThe expanded expression has type `&'static str`, and the returned file\nis not the invocation of the `file!` macro itself, but rather the\nfirst macro invocation leading up to the invocation of the `file!`\nmacro.\n\n# Examples\n\n```rust\nlet this_file = file!();\nprintln!(\"defined in file: {this_file}\");]

Not sure what that gibberish is though, got it while running rust-analyzer

[chipsenkbeil]

Resolved by #146

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.