Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Breaking Change' warning is confusing #162

Closed
stevehanson opened this issue Mar 9, 2018 · 3 comments
Closed

'Breaking Change' warning is confusing #162

stevehanson opened this issue Mar 9, 2018 · 3 comments

Comments

@stevehanson
Copy link
Contributor

The readme says:

Breaking Change: Due to a major breaking change in RN 0.40+, Use v5.x of this lib when installing from npm.

There are a couple things about this that are unclear to me:

  • Who does this breaking change affect? I.e. should users of RN less than 0.40 use a specific version of this library?
  • Is the problem with v4 of this library or the newer v6? Is it safe to use the newer v6?
@chirag04
Copy link
Owner

We need to update the readme.

Breaking Change: Due to a major breaking change in RN 0.40+, Use v5 or higher version of this lib when installing from npm.

@chirag04
Copy link
Owner

want to send a PR?

@stevehanson
Copy link
Contributor Author

@chirag04 sounds good and thanks for the clarification. I'll go ahead and submit a PR!

stevehanson added a commit to stevehanson/react-native-in-app-utils that referenced this issue Mar 12, 2018
chirag04 pushed a commit that referenced this issue Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants