Allow products to be fetched even if purchases are restricted #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i guess this is fine but at the same time we should update the purchaseProduct calls to check if they can make payments. |
|
It will error out both ways, so doesn't really make a difference in result. |
|
difference being you will get a clear "not_available" error callback to handle it in the js. at the very least we should call out in the docs for buy products to check for payments before making a purchaseProduct request. |
|
Fair enough, let me make that change. |
|
i think it's a reasonable pattern to ask for users to check first. so let's just update the docs only. |
|
Added README changes |
chirag04
reviewed
Sep 27, 2017
Readme.md
Outdated
| ### Checking if payments are allowed | ||
|
|
||
| ```javascript | ||
| InAppUtils.canMakePayments((canMakePayments, error) => { |
akshetpandey
force-pushed
the
patch-1
branch
from
c553547
to
c51d6d8
Compare
Restricting IAPs doesn't prevent us from fetching product information. A better way to handle this is to check canMakePayments method and show appropriate message on the payment screen. Update README to include canMakePayments Also add note about calling canMakePayments before purchaseProduct to show a better error message to users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restricting IAPs doesn't prevent us from fetching product information. A better way to handle this is to check canMakePayments method and show appropriate message on the payment screen.