Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update for react native 0.40 #47

Merged
merged 3 commits into from
Jan 10, 2017
Merged

update for react native 0.40 #47

merged 3 commits into from
Jan 10, 2017

Conversation

avioli
Copy link
Contributor

@avioli avioli commented Jan 10, 2017

Update iOS headers to React Native 0.40 paths.

@chirag04
Copy link
Owner

nice. Thanks.

while you are at it can you also remove react from the header search paths in the xcode project config.

@avioli
Copy link
Contributor Author

avioli commented Jan 10, 2017

Just a note that this update is BREAKING, thus highly advisable to bump the major version, not the minor.

@avioli
Copy link
Contributor Author

avioli commented Jan 10, 2017

@chirag04: I've created a branch, at my fork, called next with a major version bump (3.0.0) and an updated README for the React-Native v0.40 change.

Hope it helps.

@chirag04 chirag04 merged commit 745e4f5 into chirag04:master Jan 10, 2017
@chirag04
Copy link
Owner

merged and v3 released on npm. readme updated accordingly.

Thanks 👍

@chirag04 chirag04 mentioned this pull request Jan 10, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@avioli @chirag04