Skip to content

Commit

Permalink
[ntp] Fix enum numbering for NTPBackgroundImageSource.
Browse files Browse the repository at this point in the history
The current numbering for the enum is not in sync with what exists at chrome/browser/ui/webui/new_tab_page/new_tab_page.mojom. We need to remove an entry from enums.xml or add an entry to the mojom. Since image sources are always set when they are used we should remove the unused enum.

Verified locally using chrome://histograms

Change-Id: If3b237265576b3afbe42075809be1d52ffda9890
Bug: 1384258
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4201000
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Paul Adedeji <pauladedeji@google.com>
Cr-Commit-Position: refs/heads/main@{#1098205}
  • Loading branch information
Paul Adedeji authored and Chromium LUCI CQ committed Jan 28, 2023
1 parent 8561dfb commit b7daaba
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tools/metrics/histograms/enums.xml
Original file line number Diff line number Diff line change
Expand Up @@ -73594,7 +73594,6 @@ Called by update_net_trust_anchors.py.-->
</enum>

<enum name="NTPBackgroundImageSource">
<int value="0" label="Unknown source"/>
<int value="1" label="No image"/>
<int value="2" label="First party (NTP) theme without refresh daily enabled"/>
<int value="3" label="First party (NTP) theme with refresh daily enabled"/>
Expand Down

0 comments on commit b7daaba

Please sign in to comment.