Add send example for Nano 33 Sense #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LittleMonsterFr
suggested changes
Aug 7, 2019
| } | ||
|
|
||
| void | ||
| onSentCallback(void *chirp, uint8_t *payload, size_t length, uint8_t channel) |
There was a problem hiding this comment.
A detail but could we have function declaration on one single line ?
There was a problem hiding this comment.
done. good to merge
joextodd
commented
Aug 7, 2019
| // Process next buffer | ||
| next = (current + 1) % NUM_BUFFERS; | ||
| chirp_connect_error_code_t err = chirp_connect_process_shorts_output(chirp, data[next], BUFFER_SIZE); | ||
| if (current == 0) { |
There was a problem hiding this comment.
@dinuchiriac we can remove this current variable and instead use
if (current_buffer == buffer_one)
There was a problem hiding this comment.
In fact in can be reduced to a one liner with a ternary statement..
current_buffer = current_buffer == buffer_one ? buffer_two : buffer_one;
| Serial.print("Generated payload: "); | ||
| Serial.println(hex); | ||
|
|
||
| chirp_connect_error_code_t err = chirp_connect_send(chirp, payload, payload_len); |
There was a problem hiding this comment.
The payload is still orphan 😢
LittleMonsterFr
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.