Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bela #7

Merged
merged 8 commits into from Apr 1, 2019
Merged

Feature/bela #7

merged 8 commits into from Apr 1, 2019

Conversation

LittleMonsterFr
Copy link

What : New example - Chirp used with Bela
Why : To give more content

@LittleMonsterFr LittleMonsterFr added the enhancement New feature or request label Mar 29, 2019
Copy link
Contributor

@joextodd joextodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small changes to make!

bela/render.cpp Outdated
*
* render.cpp
*
* This exemple sends "Hello World !" when it starts and decodes it at the same
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

#include <Bela.h>
#include <stdlib.h>
#include <string.h>
#include <string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second one is the C++ one to get the std::string type

bela/README.md Outdated

Use the connector shipped with Bela to connect a speaker to the LEFT OUT connector.

This is an example of how the montage should look like :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is montage the right word here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find any other word X) Any idea ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought a montage was a selection of pictures or footage cut together with some epic music. Probably something more boring like, see the image below for an example set up

/*
* Start the auxiliary tasks
*/
if ((chirp_auxiliary_input_task = Bela_createAuxiliaryTask (&chirp_process_input_audio, 80, "chirp-auxiliary-input-task", connect)) == NULL) return false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the input task have the same priority as output?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ They have the same priority

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, I would have thought that maybe the output processing should have a higher priority to avoid any audio glitches.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay, the environment is already made for optimised audio processing, and 80 of 99 is already a high enough priority, didn't have any glitches 😄

@joextodd joextodd assigned LittleMonsterFr and unassigned joextodd Apr 1, 2019
@LittleMonsterFr
Copy link
Author

By the way, I think It'll be good for you to test it to be sure I didn't forget something obvious in the readme @joextodd

@joextodd
Copy link
Contributor

joextodd commented Apr 1, 2019

@LittleMonsterFr you can include the .a and header files in this repo now, people still need to sign up for credentials.

@joextodd
Copy link
Contributor

joextodd commented Apr 1, 2019

And add the empty credentials.h file

@joextodd
Copy link
Contributor

joextodd commented Apr 1, 2019

@LittleMonsterFr you can also commit the .so to the chirp directory - this gives us some version control on the SDK.

@joextodd joextodd assigned LittleMonsterFr and unassigned joextodd Apr 1, 2019
@joextodd joextodd merged commit beec702 into master Apr 1, 2019
@joextodd joextodd deleted the feature/bela branch April 1, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants