Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROUTING! #7

Merged
merged 2 commits into from
Mar 26, 2020
Merged

ROUTING! #7

merged 2 commits into from
Mar 26, 2020

Conversation

JeremyButt
Copy link
Collaborator

adding routing! 馃檶

@JeremyButt JeremyButt added the enhancement New feature or request label Mar 21, 2020
@s-axford
Copy link
Member

s-axford commented Mar 22, 2020 •
edited

Great work! I just went through and commented on some low hanging fruit. So that the rest of the team can better understand some of the more dense sections, some more in code comments may be nice (Chirp Router and RadioPacket for example). That way we can comment on the functionality of various functions without having to figure out what is happening.

Thanks for getting this working! HUGEEE moment!

@TimothyMather
Copy link
Collaborator

Same for me as Spencer, looks good! I'd take a look through for newlines at the ends of files but otherwise great work!

@johnnyb8
Copy link
Collaborator

Some comments or maybe a quick code walkthrough would be helpful, i agree with tim and spencer

@JeremyButt
Copy link
Collaborator Author

Fixup PR and merge

@JeremyButt
Copy link
Collaborator Author

Routing Library

@JeremyButt
Copy link
Collaborator Author

@s-axford @johnnyb8 @DelightedWaif Changes Made! let me know if there are any other changes and when im good to merge

s-axford
s-axford approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@s-axford s-axford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything now looks good to me. Some TODO's came out of this PR though, so I will create some github issues and link them.

This was referenced Mar 26, 2020
Closed
Closed
johnnyb8
johnnyb8 reviewed Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@johnnyb8 johnnyb8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

johnnyb8
johnnyb8 approved these changes Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@johnnyb8 johnnyb8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@johnnyb8 johnnyb8 merged commit 8c004cd into master Mar 26, 2020
@s-axford s-axford deleted the routing branch March 30, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-axford s-axford s-axford approved these changes

@johnnyb8 johnnyb8 johnnyb8 approved these changes

@TimothyMather TimothyMather Awaiting requested review from TimothyMather

Assignees

@JeremyButt JeremyButt

@s-axford s-axford

@TimothyMather TimothyMather

@johnnyb8 johnnyb8

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JeremyButt @s-axford @TimothyMather @johnnyb8