Fix ADR plugin variable mapping #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good catch and sorry if this has wasted some of your time.... |
|
All good, that's life and something you have to deal with in open source... Still so grateful for being able to use the software... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took me a while... A very long while...
Comparing the default ADR plugin with a transscript to JS and use it as a custom ADR plugin it still didn't work.
A device very near the geateway got DR5 right after his join and first transmission with the integrated ADR algorithm but not with the custom which I have gone over and over again and debugged with the test data and transscribed data from a real device but using the object notation from the example.
So it seems this typo was the cause for my issue...