Feature: Allow to import databases different than the default one - db-import command #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigoucr
changed the title
kporras07
requested changes
Apr 6, 2022
src/App/Commands/DbImportCommand.php
Outdated
| @@ -23,27 +24,32 @@ protected function configure() | |||
| $this->setName('db-import') | |||
| ->setDescription('Executes db import command') | |||
| ->setHelp('Import given db into default database.') | |||
| ->addArgument('filepath', InputArgument::OPTIONAL, 'File to import'); | |||
| ->addArgument('filepath', InputArgument::OPTIONAL, 'File to import') | |||
| ->addOption('dbname', NULL, InputOption::VALUE_OPTIONAL, 'The database in that we want to import the data'); | |||
There was a problem hiding this comment.
The database that you want to import the data in
src/App/Commands/DbImportCommand.php
Outdated
| @@ -23,27 +24,32 @@ protected function configure() | |||
| $this->setName('db-import') | |||
| ->setDescription('Executes db import command') | |||
| ->setHelp('Import given db into default database.') | |||
| ->addArgument('filepath', InputArgument::OPTIONAL, 'File to import'); | |||
| ->addArgument('filepath', InputArgument::OPTIONAL, 'File to import') | |||
| ->addOption('dbname', NULL, InputOption::VALUE_OPTIONAL, 'The database in that we want to import the data'); | |||
src/App/Commands/DbImportCommand.php
Outdated
| $databaseName = $_SERVER['MYSQL_DATABASE']; | ||
| if ($optionalDatabaseName = $input->getOption('dbname')) { | ||
| $databaseName = $optionalDatabaseName; | ||
| } |
There was a problem hiding this comment.
$databaseName = $input->getOption('dbname') ?? $_SERVER['MYSQL_DATABASE'];
Please try before making the code change but I think this should work
There was a problem hiding this comment.
Thx, you right , that's better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provide a new option to allow users to import databases different than the default one.
Issue Reference
Issue Number: #
What does this Pull Request do?
How can this Pull Request be tested?
Any additional notes/comments?