fix: 🐛 joinStyles should ignore undefined values

chisel-ui · Oct 23, 2022 · 6a36e59 · 6a36e59
1 parent 3b9759f
commit 6a36e59
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/styles.ts b/src/styles.ts
@@ -1,6 +1,7 @@
-export function joinStyles(...values: string[]) {
+export function joinStyles(...values: (string | undefined)[]) {
   return (
     values
+      .filter(Boolean)
       .map(value => value.split(';').map(v => v.trim()))
       .flat()
       .filter(Boolean)

diff --git a/tests/styles.ts b/tests/styles.ts
@@ -25,4 +25,13 @@ test('joinStyles', () => {
     'color: red;background: blue;font-size: 16px;line-height: 1.5;font-weight: bold',
     'three complex styles'
   )
+  assert.is(
+    joinStyles(
+      'color: red',
+      undefined,
+      'background: blue'
+    ),
+    'color: red;background: blue',
+    'ignores undefined values'
+  )
 })